tokio-rs/tokio
1
0
Fork 0
mirror of https://github.com/tokio-rs/tokio.git synced 2026-08-14 00:00:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

io: fix race in Mock::poll_write (#7882)

Browse Source
This commit is contained in:
ADD-SP
2026-02-23 20:49:37 -08:00
committed by GitHub
parent f21f2693f0
commit d18e5dfbb0
1 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tokio-test/src/io.rs
+24 -1
View File
@@ -438,7 +438,30 @@ impl AsyncWrite for Mock {
let until = Instant::now() + rem;
self.inner.sleep = Some(Box::pin(time::sleep_until(until)));
} else {
panic!("unexpected WouldBlock {}", self.pmsg());
// A race condition (TOCTOU) can occur if the
// timer expires between the `write()` call
// and `remaining_wait()` due to preemption or other
// delays. In this case, the `Wait` action is already popped by
// `action()`, so we continue to the next one.
//
// Consider the following sequence:
//
// poll_write Inner action()
// |--write()--->| |
// | |--action()---->| (returns Wait)
// |<-WouldBlk---| |
// | | |
// | <--- TIMEOUT! ---> |
// | (due to preemption, etc.) |
// | | |
// |-rem_wait()->| |
// | |--action()---->| (time's up, pop Wait)
// |<--None------| |
// | | |
// |---continue->| (process next action)
//
// See <https://github.com/tokio-rs/tokio/issues/7881>.
continue;
}
}
Ok(0) => {