tokio-rs/tokio
1
0
Fork 0
mirror of https://github.com/tokio-rs/tokio.git synced 2026-08-07 00:00:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

metrics: correctly update atomics in IoDriverMetrics (#4725)

Browse Source 
Updating an atomic variable with a load followed by a store is racy.  It
defeats the entire purpose of using atomic variables, and can result in
"lost" updates.  Instead, use fetch_add .
This commit is contained in:
Alan Somers
2022-05-30 11:14:56 +02:00
committed by GitHub
parent f6c0405084
commit 6c0a9942ba
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tokio/src/runtime/metrics/io.rs
+3 -9
View File
@@ -11,20 +11,14 @@ pub(crate) struct IoDriverMetrics {
impl IoDriverMetrics {
pub(crate) fn incr_fd_count(&self) {
let prev = self.fd_registered_count.load(Relaxed);
let new = prev.wrapping_add(1);
self.fd_registered_count.store(new, Relaxed);
self.fd_registered_count.fetch_add(1, Relaxed);
}
pub(crate) fn dec_fd_count(&self) {
let prev = self.fd_deregistered_count.load(Relaxed);
let new = prev.wrapping_add(1);
self.fd_deregistered_count.store(new, Relaxed);
self.fd_deregistered_count.fetch_add(1, Relaxed);
}
pub(crate) fn incr_ready_count_by(&self, amt: u64) {
let prev = self.ready_count.load(Relaxed);
let new = prev.wrapping_add(amt);
self.ready_count.store(new, Relaxed);
self.ready_count.fetch_add(amt, Relaxed);
}
}