Enhance documentation of tokio::task::block_in_place (#2155)

This commit is contained in:
gliderkite
2020-01-22 11:34:09 -05:00
committed by Lucio Franco
parent 90969420a2
commit 5bbf976268
2 changed files with 9 additions and 1 deletions
+3 -1
View File
@@ -26,7 +26,9 @@ cfg_blocking! {
ON_BLOCK.with(|ob| {
let allow_blocking = ob
.get()
.expect("can only call blocking when on Tokio runtime");
// `block_in_place` can only be called from a spawned task when
// working with the threaded scheduler.
.expect("can call blocking only when running in a spawned task");
// This is safe, because ON_BLOCK was set from an &mut dyn FnMut in the worker that wraps
// the worker's operation, and is unset just prior to when the FnMut is dropped.
+6
View File
@@ -10,6 +10,12 @@ cfg_rt_threaded! {
/// (possibly new) thread, and only then poll the task. Note that this requires
/// additional synchronization.
///
/// # Note
///
/// This function can only be called from a spawned task when working with
/// the [threaded scheduler](https://docs.rs/tokio/0.2.10/tokio/runtime/index.html#threaded-scheduler).
/// Consider using [tokio::task::spawn_blocking](https://docs.rs/tokio/0.2.10/tokio/task/fn.spawn_blocking.html).
///
/// # Examples
///
/// ```