mirror of
https://github.com/tokio-rs/tokio.git
synced 2026-08-18 00:00:09 +02:00
Ivan Petkov
e20dff39ce
This updates the tokio `Command` and `Child` behavior to match that of the stdlib: spawned processes will *not* be automatically killed when the handle is dropped Unlike the stdlib, any dropped (unix) processes may be reaped by tokio behind-the-scenes after they exit and if new processes are awaited, which mitigates the risks of piling up unreaped zombie unix processes A `Command::kill_on_drop` method is added to allow the caller to control whether the spawned child should be killed when the handle is dropped. By default, this value is `false`. The `Child::forget` method has been removed, as it is superseded by `Command::kill_on_drop`
63 lines
1.5 KiB
Rust
63 lines
1.5 KiB
Rust
#![warn(rust_2018_idioms)]
|
|
#![cfg(feature = "full")]
|
|
#![cfg(unix)]
|
|
|
|
use tokio::process::Command;
|
|
use tokio::runtime;
|
|
|
|
use futures::future::FutureExt;
|
|
use futures::stream::FuturesOrdered;
|
|
use std::process::Stdio;
|
|
use std::sync::atomic::{AtomicBool, Ordering};
|
|
use std::sync::Arc;
|
|
use std::thread;
|
|
use std::time::Duration;
|
|
|
|
fn run_test() {
|
|
let finished = Arc::new(AtomicBool::new(false));
|
|
let finished_clone = finished.clone();
|
|
|
|
thread::spawn(move || {
|
|
let mut rt = runtime::Builder::new()
|
|
.basic_scheduler()
|
|
.enable_all()
|
|
.build()
|
|
.unwrap();
|
|
|
|
let mut futures = FuturesOrdered::new();
|
|
rt.block_on(async {
|
|
for i in 0..2 {
|
|
futures.push(
|
|
Command::new("echo")
|
|
.arg(format!("I am spawned process #{}", i))
|
|
.stdin(Stdio::null())
|
|
.stdout(Stdio::null())
|
|
.stderr(Stdio::null())
|
|
.kill_on_drop(true)
|
|
.spawn()
|
|
.unwrap()
|
|
.boxed(),
|
|
)
|
|
}
|
|
});
|
|
|
|
drop(rt);
|
|
finished_clone.store(true, Ordering::SeqCst);
|
|
});
|
|
|
|
thread::sleep(Duration::from_millis(1000));
|
|
assert!(
|
|
finished.load(Ordering::SeqCst),
|
|
"FINISHED flag not set, maybe we deadlocked?"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn issue_42() {
|
|
let max = 10;
|
|
for i in 0..max {
|
|
println!("running {}/{}", i, max);
|
|
run_test()
|
|
}
|
|
}
|