mirror of
https://github.com/tokio-rs/tokio.git
synced 2026-09-09 00:00:08 +02:00
## Motivation Was determined that having the span! macro default to the TRACE level is probably not ideal (see discussion on #952). Closes #1013 ## Solution Remove default trace level and make log lvl mandatory on span! macro, and add the respective `trace_span!`, `debug_span!`, `info_span!`, `warn_span!` and `error_span!` macros that behave as span! macro, but with defined log levels ## Notes I think this is it, also removed some captures that were repeated, and some testcases that also seemed repeated after adding the mandatory log level, but please review it, if more tests or examples are needed happy to provide (tried to find a way to get the generated macros log level, but didn't find one, if there is a way i can add tests to assert that the generated macro has the matching log level ). thanks
158 lines
3.7 KiB
Rust
158 lines
3.7 KiB
Rust
#![feature(test)]
|
|
|
|
#[macro_use]
|
|
extern crate tokio_trace;
|
|
extern crate test;
|
|
use test::Bencher;
|
|
use tokio_trace::Level;
|
|
|
|
use std::{
|
|
fmt,
|
|
sync::{Mutex, MutexGuard},
|
|
};
|
|
use tokio_trace::{field, span, Event, Id, Metadata};
|
|
|
|
/// A subscriber that is enabled but otherwise does nothing.
|
|
struct EnabledSubscriber;
|
|
|
|
impl tokio_trace::Subscriber for EnabledSubscriber {
|
|
fn new_span(&self, span: &span::Attributes) -> Id {
|
|
let _ = span;
|
|
Id::from_u64(0)
|
|
}
|
|
|
|
fn event(&self, event: &Event) {
|
|
let _ = event;
|
|
}
|
|
|
|
fn record(&self, span: &Id, values: &span::Record) {
|
|
let _ = (span, values);
|
|
}
|
|
|
|
fn record_follows_from(&self, span: &Id, follows: &Id) {
|
|
let _ = (span, follows);
|
|
}
|
|
|
|
fn enabled(&self, metadata: &Metadata) -> bool {
|
|
let _ = metadata;
|
|
true
|
|
}
|
|
|
|
fn enter(&self, span: &Id) {
|
|
let _ = span;
|
|
}
|
|
|
|
fn exit(&self, span: &Id) {
|
|
let _ = span;
|
|
}
|
|
}
|
|
|
|
/// Simulates a subscriber that records span data.
|
|
struct VisitingSubscriber(Mutex<String>);
|
|
|
|
struct Visitor<'a>(MutexGuard<'a, String>);
|
|
|
|
impl<'a> field::Visit for Visitor<'a> {
|
|
fn record_debug(&mut self, _field: &field::Field, value: &fmt::Debug) {
|
|
use std::fmt::Write;
|
|
let _ = write!(&mut *self.0, "{:?}", value);
|
|
}
|
|
}
|
|
|
|
impl tokio_trace::Subscriber for VisitingSubscriber {
|
|
fn new_span(&self, span: &span::Attributes) -> Id {
|
|
let mut visitor = Visitor(self.0.lock().unwrap());
|
|
span.record(&mut visitor);
|
|
Id::from_u64(0)
|
|
}
|
|
|
|
fn record(&self, _span: &Id, values: &span::Record) {
|
|
let mut visitor = Visitor(self.0.lock().unwrap());
|
|
values.record(&mut visitor);
|
|
}
|
|
|
|
fn event(&self, event: &Event) {
|
|
let mut visitor = Visitor(self.0.lock().unwrap());
|
|
event.record(&mut visitor);
|
|
}
|
|
|
|
fn record_follows_from(&self, span: &Id, follows: &Id) {
|
|
let _ = (span, follows);
|
|
}
|
|
|
|
fn enabled(&self, metadata: &Metadata) -> bool {
|
|
let _ = metadata;
|
|
true
|
|
}
|
|
|
|
fn enter(&self, span: &Id) {
|
|
let _ = span;
|
|
}
|
|
|
|
fn exit(&self, span: &Id) {
|
|
let _ = span;
|
|
}
|
|
}
|
|
|
|
const N_SPANS: usize = 100;
|
|
|
|
#[bench]
|
|
fn span_no_fields(b: &mut Bencher) {
|
|
tokio_trace::subscriber::with_default(EnabledSubscriber, || {
|
|
b.iter(|| span!(Level::TRACE, "span"))
|
|
});
|
|
}
|
|
|
|
#[bench]
|
|
fn enter_span(b: &mut Bencher) {
|
|
tokio_trace::subscriber::with_default(EnabledSubscriber, || {
|
|
b.iter(|| test::black_box(span!(Level::TRACE, "span").enter(|| {})))
|
|
});
|
|
}
|
|
|
|
#[bench]
|
|
fn span_repeatedly(b: &mut Bencher) {
|
|
#[inline]
|
|
fn mk_span(i: u64) -> tokio_trace::Span {
|
|
span!(Level::TRACE, "span", i = i)
|
|
}
|
|
|
|
let n = test::black_box(N_SPANS);
|
|
tokio_trace::subscriber::with_default(EnabledSubscriber, || {
|
|
b.iter(|| (0..n).fold(mk_span(0), |_, i| mk_span(i as u64)))
|
|
});
|
|
}
|
|
|
|
#[bench]
|
|
fn span_with_fields(b: &mut Bencher) {
|
|
tokio_trace::subscriber::with_default(EnabledSubscriber, || {
|
|
b.iter(|| {
|
|
span!(
|
|
Level::TRACE,
|
|
"span",
|
|
foo = "foo",
|
|
bar = "bar",
|
|
baz = 3,
|
|
quuux = tokio_trace::field::debug(0.99)
|
|
)
|
|
})
|
|
});
|
|
}
|
|
|
|
#[bench]
|
|
fn span_with_fields_record(b: &mut Bencher) {
|
|
let subscriber = VisitingSubscriber(Mutex::new(String::from("")));
|
|
tokio_trace::subscriber::with_default(subscriber, || {
|
|
b.iter(|| {
|
|
span!(
|
|
Level::TRACE,
|
|
"span",
|
|
foo = "foo",
|
|
bar = "bar",
|
|
baz = 3,
|
|
quuux = tokio_trace::field::debug(0.99)
|
|
)
|
|
})
|
|
});
|
|
}
|