buf: Inital pass at updating BufStream (#1355)

Cargo.toml

@@ -2,7 +2,7 @@
 
 members = [
   "tokio",
-  # "tokio-buf",
+  "tokio-buf",
   "tokio-codec",
   "tokio-current-thread",
   "tokio-executor",

tokio-buf/Cargo.toml

@@ -24,11 +24,10 @@ publish = false
 [dependencies]
 bytes = "0.4.10"
 either = { version =  "1.5", optional = true}
-futures = "0.1.23"
 
 [features]
-default = ["util"]
+# default = ["util"]
-util = ["bytes/either", "either"]
+# util = ["bytes/either", "either"]
 
 [dev-dependencies]
 tokio-mock-task = "0.1.1"

tokio-buf/src/lib.rs

@@ -15,20 +15,20 @@
 //! instead of yielding arbitrary values, it only yields types that implement
 //! `Buf` (i.e, byte collections).
 
-mod never;
+// mod never;
 mod size_hint;
-mod str;
+// mod str;
-mod u8;
+// mod u8;
-#[cfg(feature = "util")]
+// #[cfg(feature = "util")]
-pub mod util;
+// pub mod util;
 
 pub use self::size_hint::SizeHint;
-#[doc(inline)]
+// #[doc(inline)]
-#[cfg(feature = "util")]
+// #[cfg(feature = "util")]
-pub use crate::util::BufStreamExt;
+// pub use crate::util::BufStreamExt;
 
 use bytes::Buf;
-use futures::Poll;
+use std::task::{Context, Poll};
 
 /// An asynchronous stream of bytes.
 ///
@@ -68,7 +68,7 @@ pub trait BufStream {
     ///
     /// Once a stream is finished, i.e. `Ready(None)` has been returned, further
     /// calls to `poll_buf` may result in a panic or other "bad behavior".
-    fn poll_buf(&mut self) -> Poll<Option<Self::Item>, Self::Error>;
+    fn poll_buf(&mut self, cx: &mut Context<'_>) -> Poll<Option<Result<Self::Item, Self::Error>>>;
 
     /// Returns the bounds on the remaining length of the stream.
     ///

tokio-buf/tests/buf_stream.rs

@@ -1,5 +1,8 @@
 use tokio_buf::BufStream;
 
-// Ensures that `BufStream` can be a trait object
+#[test]
-#[allow(dead_code)]
+fn object_safe() {
-fn obj(_: &mut dyn BufStream<Item = u32, Error = ()>) {}
+    // Ensures that `BufStream` can be a trait object
+    #[allow(dead_code)]
+    fn obj(_: &mut dyn BufStream<Item = u32, Error = ()>) {}
+}

tokio-buf/tests/chain.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 #![cfg(feature = "util")]
 
 use futures::Async::*;

tokio-buf/tests/collect.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 #![cfg(feature = "util")]
 
 use bytes::Bytes;

tokio-buf/tests/iter.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 use futures::Async::*;
 use std::io::Cursor;
 use tokio_buf::{util, BufStream};

tokio-buf/tests/limit.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 #![cfg(feature = "util")]
 
 use futures::Async::*;

tokio-buf/tests/stream.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 use futures::sync::mpsc;
 use futures::Async::*;
 use std::io::Cursor;

tokio-buf/tests/string.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 use futures::Async::*;
 use std::fmt;
 use tokio_buf::BufStream;

tokio-buf/tests/support.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "broken")]
 #![allow(unused)]
 
 use bytes::Buf;