From cf486361d0346a49d2e6a5c001df09375a1afef8 Mon Sep 17 00:00:00 2001 From: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Date: Wed, 22 Feb 2023 13:54:17 -0500 Subject: [PATCH] ci: remove cargo-semver-checks flags that are no longer necessary (#5496) These flags were previously only needed due to a bug in the `cargo-semver-checks` CLI logic. The correct behavior (available as of v0.18.3) for `cargo-semver-checks` is to ignore `publish = false` crates when scanning a workspace, *unless* those crates are specifically selected for checking. All the crates being excluded here are `publish = false` so they are already excluded by the default behavior, so all `--exclude` flags are no-ops. --- .github/workflows/ci.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 54f91488e..0c0061600 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -245,13 +245,7 @@ jobs: tool: cargo-semver-checks - name: Check semver compatibility run: | - cargo semver-checks check-release \ - --release-type minor \ - --exclude benches \ - --exclude examples \ - --exclude stress-test \ - --exclude tests-build \ - --exclude tests-integration + cargo semver-checks check-release --release-type minor cross-check: name: cross-check