From 9264b837d897dcdf974703a6739132b995e669bc Mon Sep 17 00:00:00 2001
From: Mikail Bagishov <bagishov.mikail@yandex.ru>
Date: Sun, 31 May 2020 15:49:22 +0300
Subject: [PATCH] test: fix all clippy lints in tests (#2573)

---
 ci/azure-clippy.yml                     | 4 ++--
 tokio/src/sync/tests/semaphore_batch.rs | 2 +-
 tokio/tests/macros_join.rs              | 1 +
 tokio/tests/macros_select.rs            | 1 +
 tokio/tests/macros_try_join.rs          | 1 +
 tokio/tests/sync_mutex_owned.rs         | 2 +-
 tokio/tests/time_delay_queue.rs         | 1 +
 7 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/ci/azure-clippy.yml b/ci/azure-clippy.yml
index 58ab318f7..b843223f4 100644
--- a/ci/azure-clippy.yml
+++ b/ci/azure-clippy.yml
@@ -12,5 +12,5 @@ jobs:
         cargo clippy --version
       displayName: Install clippy
     - script: |
-        cargo clippy --all --all-features
-      displayName: cargo clippy --all
+        cargo clippy --all --all-features --tests
+      displayName: cargo clippy --all --tests
diff --git a/tokio/src/sync/tests/semaphore_batch.rs b/tokio/src/sync/tests/semaphore_batch.rs
index 60f3f231e..9342cd1cb 100644
--- a/tokio/src/sync/tests/semaphore_batch.rs
+++ b/tokio/src/sync/tests/semaphore_batch.rs
@@ -236,7 +236,7 @@ fn close_semaphore_notifies_permit2() {
 #[test]
 fn cancel_acquire_releases_permits() {
     let s = Semaphore::new(10);
-    let _permit1 = s.try_acquire(4).expect("uncontended try_acquire succeeds");
+    s.try_acquire(4).expect("uncontended try_acquire succeeds");
     assert_eq!(6, s.available_permits());
 
     let mut acquire = task::spawn(s.acquire(8));
diff --git a/tokio/tests/macros_join.rs b/tokio/tests/macros_join.rs
index d9b748d9a..169e898f9 100644
--- a/tokio/tests/macros_join.rs
+++ b/tokio/tests/macros_join.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::blacklisted_name)]
 use tokio::sync::oneshot;
 use tokio_test::{assert_pending, assert_ready, task};
 
diff --git a/tokio/tests/macros_select.rs b/tokio/tests/macros_select.rs
index c08e816a0..6f027f3bd 100644
--- a/tokio/tests/macros_select.rs
+++ b/tokio/tests/macros_select.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::blacklisted_name)]
 use tokio::sync::{mpsc, oneshot};
 use tokio::task;
 use tokio_test::{assert_ok, assert_pending, assert_ready};
diff --git a/tokio/tests/macros_try_join.rs b/tokio/tests/macros_try_join.rs
index faa55421a..a92515326 100644
--- a/tokio/tests/macros_try_join.rs
+++ b/tokio/tests/macros_try_join.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::blacklisted_name)]
 use tokio::sync::oneshot;
 use tokio_test::{assert_pending, assert_ready, task};
 
diff --git a/tokio/tests/sync_mutex_owned.rs b/tokio/tests/sync_mutex_owned.rs
index eef966fd4..394a6708b 100644
--- a/tokio/tests/sync_mutex_owned.rs
+++ b/tokio/tests/sync_mutex_owned.rs
@@ -36,7 +36,7 @@ fn straight_execution() {
 fn readiness() {
     let l = Arc::new(Mutex::new(100));
     let mut t1 = spawn(l.clone().lock_owned());
-    let mut t2 = spawn(l.clone().lock_owned());
+    let mut t2 = spawn(l.lock_owned());
 
     let g = assert_ready!(t1.poll());
 
diff --git a/tokio/tests/time_delay_queue.rs b/tokio/tests/time_delay_queue.rs
index 3cf2d1cd0..f04576d5a 100644
--- a/tokio/tests/time_delay_queue.rs
+++ b/tokio/tests/time_delay_queue.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::blacklisted_name)]
 #![warn(rust_2018_idioms)]
 #![cfg(feature = "full")]