chore: use ready macro from futures-core (#1300)

tokio-sync/Cargo.toml

@@ -22,13 +22,13 @@ categories = ["asynchronous"]
 publish = false
 
 [features]
-async-traits = ["tokio-futures", "futures-core-preview"]
+async-traits = ["tokio-futures"]
 
 [dependencies]
 async-util = { git = "https://github.com/tokio-rs/async" }
 tokio-futures = { path = "../tokio-futures", optional = true }
 fnv = "1.0.6"
-futures-core-preview = { version = "0.3.0-alpha.17", optional = true }
+futures-core-preview = { version = "0.3.0-alpha.17" }
 
 [dev-dependencies]
 env_logger = { version = "0.5", default-features = false }

tokio-sync/src/lib.rs

@@ -21,19 +21,6 @@ macro_rules! debug {
     }
 }
 
-/// Unwrap a ready value or propagate `Poll::Pending`.
-#[macro_export]
-macro_rules! ready {
-    ($e:expr) => {{
-        use std::task::Poll::{Pending, Ready};
-
-        match $e {
-            Ready(v) => v,
-            Pending => return Pending,
-        }
-    }};
-}
-
 macro_rules! if_fuzz {
     ($($t:tt)*) => {{
         if false { $($t)* }

tokio-sync/src/lock.rs

@@ -42,6 +42,7 @@
 
 use crate::semaphore;
 
+use futures_core::ready;
 use std::cell::UnsafeCell;
 use std::fmt;
 use std::future::Future;

tokio-sync/src/oneshot.rs

@@ -2,6 +2,7 @@
 
 use crate::loom::{sync::atomic::AtomicUsize, sync::CausalCell};
 
+use futures_core::ready;
 use std::fmt;
 use std::future::Future;
 use std::mem::{self, ManuallyDrop};

tokio-sync/src/watch.rs

@@ -58,6 +58,7 @@ use crate::task::AtomicWaker;
 use core::task::Poll::{Pending, Ready};
 use core::task::{Context, Poll};
 use fnv::FnvHashMap;
+use futures_core::ready;
 use std::ops;
 use std::sync::atomic::AtomicUsize;
 use std::sync::atomic::Ordering::SeqCst;

tokio-sync/tests/fuzz_oneshot.rs

@@ -1,19 +1,6 @@
 #![deny(warnings, rust_2018_idioms)]
 #![feature(async_await)]
 
-/// Unwrap a ready value or propagate `Async::Pending`.
-#[macro_export]
-macro_rules! ready {
-    ($e:expr) => {{
-        use std::task::Poll::{Pending, Ready};
-
-        match $e {
-            Ready(v) => v,
-            Pending => return Pending,
-        }
-    }};
-}
-
 #[path = "../src/oneshot.rs"]
 #[allow(warnings)]
 mod oneshot;

tokio-sync/tests/fuzz_semaphore.rs

@@ -10,6 +10,7 @@ mod semaphore;
 use crate::semaphore::*;
 
 use async_util::future::poll_fn;
+use futures_core::ready;
 use loom::futures::block_on;
 use loom::thread;
 use std::future::Future;
@@ -20,19 +21,6 @@ use std::sync::Arc;
 use std::task::Poll::Ready;
 use std::task::{Context, Poll};
 
-/// Unwrap a ready value or propagate `Poll::Pending`.
-#[macro_export]
-macro_rules! ready {
-    ($e:expr) => {{
-        use std::task::Poll::{Pending, Ready};
-
-        match $e {
-            Ready(v) => v,
-            Pending => return Pending,
-        }
-    }};
-}
-
 #[test]
 fn basic_usage() {
     const NUM: usize = 2;