chore: apply unreachable_pub and missing_debug_implementations to all crates (#1424)

tokio-process/src/lib.rs

@@ -1,4 +1,12 @@
 #![doc(html_root_url = "https://docs.rs/tokio-process/0.3.0-alpha.1")]
+#![warn(
+    missing_debug_implementations,
+    missing_docs,
+    rust_2018_idioms,
+    unreachable_pub
+)]
+#![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
+#![feature(async_await)]
 
 //! An implementation of asynchronous process management for Tokio.
 //!
@@ -117,11 +125,6 @@
 //! `tokio_process::Child` is dropped. The behavior of the standard library can
 //! be regained with the `Child::forget` method.
 
-#![doc(html_root_url = "https://docs.rs/tokio-process/0.3.0")]
-#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
-#![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
-#![feature(async_await)]
-
 #[cfg(unix)]
 #[macro_use]
 extern crate lazy_static;

tokio-process/src/unix/mod.rs

@@ -81,7 +81,7 @@ impl OrphanQueue<process::Child> for GlobalOrphanQueue {
 }
 
 #[must_use = "futures do nothing unless polled"]
-pub struct Child {
+pub(crate) struct Child {
     inner: Reaper<process::Child, GlobalOrphanQueue, Signal>,
 }
 
@@ -112,7 +112,7 @@ pub(crate) fn spawn_child(cmd: &mut process::Command, handle: &Handle) -> io::Re
 }
 
 impl Child {
-    pub fn id(&self) -> u32 {
+    pub(crate) fn id(&self) -> u32 {
         self.inner.id()
     }
 }
@@ -132,7 +132,7 @@ impl Future for Child {
 }
 
 #[derive(Debug)]
-pub struct Fd<T> {
+pub(crate) struct Fd<T> {
     inner: T,
 }
 
@@ -196,9 +196,9 @@ where
     }
 }
 
-pub type ChildStdin = PollEvented<Fd<process::ChildStdin>>;
-pub type ChildStdout = PollEvented<Fd<process::ChildStdout>>;
-pub type ChildStderr = PollEvented<Fd<process::ChildStderr>>;
+pub(crate) type ChildStdin = PollEvented<Fd<process::ChildStdin>>;
+pub(crate) type ChildStdout = PollEvented<Fd<process::ChildStdout>>;
+pub(crate) type ChildStderr = PollEvented<Fd<process::ChildStderr>>;
 
 fn stdio<T>(option: Option<T>, handle: &Handle) -> io::Result<Option<PollEvented<Fd<T>>>>
 where

tokio-process/src/windows.rs

@@ -45,7 +45,7 @@ use winapi::um::winbase::*;
 use winapi::um::winnt::*;
 
 #[must_use = "futures do nothing unless polled"]
-pub struct Child {
+pub(crate) struct Child {
     child: process::Child,
     waiting: Option<Waiting>,
 }
@@ -87,7 +87,7 @@ pub(crate) fn spawn_child(cmd: &mut process::Command, handle: &Handle) -> io::Re
 }
 
 impl Child {
-    pub fn id(&self) -> u32 {
+    pub(crate) fn id(&self) -> u32 {
         self.child.id()
     }
 }
@@ -161,7 +161,7 @@ unsafe extern "system" fn callback(ptr: PVOID, _timer_fired: BOOLEAN) {
     let _ = complete.take().unwrap().send(());
 }
 
-pub fn try_wait(child: &process::Child) -> io::Result<Option<ExitStatus>> {
+pub(crate) fn try_wait(child: &process::Child) -> io::Result<Option<ExitStatus>> {
     unsafe {
         match WaitForSingleObject(child.as_raw_handle(), 0) {
             WAIT_OBJECT_0 => {}
@@ -178,9 +178,9 @@ pub fn try_wait(child: &process::Child) -> io::Result<Option<ExitStatus>> {
     }
 }
 
-pub type ChildStdin = PollEvented<NamedPipe>;
-pub type ChildStdout = PollEvented<NamedPipe>;
-pub type ChildStderr = PollEvented<NamedPipe>;
+pub(crate) type ChildStdin = PollEvented<NamedPipe>;
+pub(crate) type ChildStdout = PollEvented<NamedPipe>;
+pub(crate) type ChildStderr = PollEvented<NamedPipe>;
 
 fn stdio<T>(option: Option<T>, handle: &Handle) -> io::Result<Option<PollEvented<NamedPipe>>>
 where