tokio-rs/bytes
1
0
Fork 0
mirror of https://github.com/tokio-rs/bytes.git synced 2026-08-13 00:00:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make BufMut an unsafe trait (#432)

Browse Source 
Users of `BufMut` are unable to defend against incorrect implementations
of `BufMut`, this makes the trait unsafe to implement.

Fixes #329
This commit is contained in:
Carl Lerche
2020-10-16 15:45:38 -07:00
committed by GitHub
parent 94c543f74b
commit ced050730c
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/buf/buf_mut.rs
+5 -5
View File
@@ -30,7 +30,7 @@ use alloc::{boxed::Box, vec::Vec};
///
/// assert_eq!(buf, b"hello world");
/// ```
pub trait BufMut {
pub unsafe trait BufMut {
/// Returns the number of bytes that can be written from the current
/// position until the end of the buffer is reached.
///
@@ -992,15 +992,15 @@ macro_rules! deref_forward_bufmut {
};
}
impl<T: BufMut + ?Sized> BufMut for &mut T {
unsafe impl<T: BufMut + ?Sized> BufMut for &mut T {
deref_forward_bufmut!();
}
impl<T: BufMut + ?Sized> BufMut for Box<T> {
unsafe impl<T: BufMut + ?Sized> BufMut for Box<T> {
deref_forward_bufmut!();
}
impl BufMut for &mut [u8] {
unsafe impl BufMut for &mut [u8] {
#[inline]
fn remaining_mut(&self) -> usize {
self.len()
@@ -1020,7 +1020,7 @@ impl BufMut for &mut [u8] {
}
}
impl BufMut for Vec<u8> {
unsafe impl BufMut for Vec<u8> {
#[inline]
fn remaining_mut(&self) -> usize {
usize::MAX - self.len()