mirror of
https://github.com/tokio-rs/bytes.git
synced 2026-08-29 00:00:15 +02:00
Add inline tags to UninitSlice methods (#443)
This appears to be the primary cause of significant performance regressions in the `prost` test suite in the 0.5 to 0.6 transition. See danburkert/prost#381.
This commit is contained in:
@@ -40,6 +40,7 @@ impl UninitSlice {
|
|||||||
///
|
///
|
||||||
/// let slice = unsafe { UninitSlice::from_raw_parts_mut(ptr, len) };
|
/// let slice = unsafe { UninitSlice::from_raw_parts_mut(ptr, len) };
|
||||||
/// ```
|
/// ```
|
||||||
|
#[inline]
|
||||||
pub unsafe fn from_raw_parts_mut<'a>(ptr: *mut u8, len: usize) -> &'a mut UninitSlice {
|
pub unsafe fn from_raw_parts_mut<'a>(ptr: *mut u8, len: usize) -> &'a mut UninitSlice {
|
||||||
let maybe_init: &mut [MaybeUninit<u8>] =
|
let maybe_init: &mut [MaybeUninit<u8>] =
|
||||||
core::slice::from_raw_parts_mut(ptr as *mut _, len);
|
core::slice::from_raw_parts_mut(ptr as *mut _, len);
|
||||||
@@ -64,6 +65,7 @@ impl UninitSlice {
|
|||||||
///
|
///
|
||||||
/// assert_eq!(b"boo", &data[..]);
|
/// assert_eq!(b"boo", &data[..]);
|
||||||
/// ```
|
/// ```
|
||||||
|
#[inline]
|
||||||
pub fn write_byte(&mut self, index: usize, byte: u8) {
|
pub fn write_byte(&mut self, index: usize, byte: u8) {
|
||||||
assert!(index < self.len());
|
assert!(index < self.len());
|
||||||
|
|
||||||
@@ -90,6 +92,7 @@ impl UninitSlice {
|
|||||||
///
|
///
|
||||||
/// assert_eq!(b"bar", &data[..]);
|
/// assert_eq!(b"bar", &data[..]);
|
||||||
/// ```
|
/// ```
|
||||||
|
#[inline]
|
||||||
pub fn copy_from_slice(&mut self, src: &[u8]) {
|
pub fn copy_from_slice(&mut self, src: &[u8]) {
|
||||||
use core::ptr;
|
use core::ptr;
|
||||||
|
|
||||||
@@ -116,6 +119,7 @@ impl UninitSlice {
|
|||||||
/// let mut slice = &mut data[..];
|
/// let mut slice = &mut data[..];
|
||||||
/// let ptr = BufMut::chunk_mut(&mut slice).as_mut_ptr();
|
/// let ptr = BufMut::chunk_mut(&mut slice).as_mut_ptr();
|
||||||
/// ```
|
/// ```
|
||||||
|
#[inline]
|
||||||
pub fn as_mut_ptr(&mut self) -> *mut u8 {
|
pub fn as_mut_ptr(&mut self) -> *mut u8 {
|
||||||
self.0.as_mut_ptr() as *mut _
|
self.0.as_mut_ptr() as *mut _
|
||||||
}
|
}
|
||||||
@@ -133,6 +137,7 @@ impl UninitSlice {
|
|||||||
///
|
///
|
||||||
/// assert_eq!(len, 3);
|
/// assert_eq!(len, 3);
|
||||||
/// ```
|
/// ```
|
||||||
|
#[inline]
|
||||||
pub fn len(&self) -> usize {
|
pub fn len(&self) -> usize {
|
||||||
self.0.len()
|
self.0.len()
|
||||||
}
|
}
|
||||||
@@ -150,6 +155,7 @@ macro_rules! impl_index {
|
|||||||
impl Index<$t> for UninitSlice {
|
impl Index<$t> for UninitSlice {
|
||||||
type Output = UninitSlice;
|
type Output = UninitSlice;
|
||||||
|
|
||||||
|
#[inline]
|
||||||
fn index(&self, index: $t) -> &UninitSlice {
|
fn index(&self, index: $t) -> &UninitSlice {
|
||||||
let maybe_uninit: &[MaybeUninit<u8>] = &self.0[index];
|
let maybe_uninit: &[MaybeUninit<u8>] = &self.0[index];
|
||||||
unsafe { &*(maybe_uninit as *const [MaybeUninit<u8>] as *const UninitSlice) }
|
unsafe { &*(maybe_uninit as *const [MaybeUninit<u8>] as *const UninitSlice) }
|
||||||
@@ -157,6 +163,7 @@ macro_rules! impl_index {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl IndexMut<$t> for UninitSlice {
|
impl IndexMut<$t> for UninitSlice {
|
||||||
|
#[inline]
|
||||||
fn index_mut(&mut self, index: $t) -> &mut UninitSlice {
|
fn index_mut(&mut self, index: $t) -> &mut UninitSlice {
|
||||||
let maybe_uninit: &mut [MaybeUninit<u8>] = &mut self.0[index];
|
let maybe_uninit: &mut [MaybeUninit<u8>] = &mut self.0[index];
|
||||||
unsafe { &mut *(maybe_uninit as *mut [MaybeUninit<u8>] as *mut UninitSlice) }
|
unsafe { &mut *(maybe_uninit as *mut [MaybeUninit<u8>] as *mut UninitSlice) }
|
||||||
|
|||||||
Reference in New Issue
Block a user