mirror of
https://github.com/tokio-rs/axum.git
synced 2026-08-20 00:00:11 +02:00
* Only allow last extractor to mutate the request * Change `FromRequest` and add `FromRequestParts` trait (#1275) * Add `Once`/`Mut` type parameter for `FromRequest` and `RequestParts` * 🪄 * split traits * `FromRequest` for tuples * Remove `BodyAlreadyExtracted` * don't need fully qualified path * don't export `Once` and `Mut` * remove temp tests * depend on axum again Co-authored-by: Jonas Platte <[email protected]> * Port `Handler` and most extractors (#1277) * Port `Handler` and most extractors * Put `M` inside `Handler` impls, not trait itself * comment out tuples for now * fix lints * Reorder arguments to `Handler` (#1281) I think `Request<B>, Arc<S>` is better since its consistent with `FromRequest` and `FromRequestParts`. * Port most things in axum-extra (#1282) * Port `#[derive(TypedPath)]` and `#[debug_handler]` (#1283) * port #[derive(TypedPath)] * wip: #[debug_handler] * fix #[debug_handler] * don't need itertools * also require `Send` * update expected error * support fully qualified `self` * Implement FromRequest[Parts] for tuples (#1286) * Port docs for axum and axum-core (#1285) * Port axum-extra (#1287) * Port axum-extra * Update axum-core/Cargo.toml Co-authored-by: Jonas Platte <[email protected]> * remove `impl FromRequest for Either*` Co-authored-by: Jonas Platte <[email protected]> * New FromRequest[Parts] trait cleanup (#1288) * Make private module truly private again * Simplify tuple FromRequest implementation * Port `#[derive(FromRequest)]` (#1289) * fix tests * fix docs * revert examples * fix docs link * fix intra docs links * Port examples (#1291) * Document wrapping other extractors (#1292) * axum-extra doesn't need to depend on axum-core (#1294) Missed this in https://github.com/tokio-rs/axum/pull/1287 * Add `FromRequest` changes to changelogs (#1293) * Update changelog * Remove default type for `S` in `Handler` * Clarify which types have default types for `S` * Apply suggestions from code review Co-authored-by: Jonas Platte <[email protected]> Co-authored-by: Jonas Platte <[email protected]> * remove unused import * Rename `Mut` and `Once` (#1296) * fix trybuild expected output Co-authored-by: Jonas Platte <[email protected]>
199 lines
5.5 KiB
Rust
199 lines
5.5 KiB
Rust
use axum::{
|
|
async_trait,
|
|
extract::{Extension, FromRequest, FromRequestParts},
|
|
};
|
|
use http::{request::Parts, Request};
|
|
use std::ops::{Deref, DerefMut};
|
|
|
|
/// Cache results of other extractors.
|
|
///
|
|
/// `Cached` wraps another extractor and caches its result in [request extensions].
|
|
///
|
|
/// This is useful if you have a tree of extractors that share common sub-extractors that
|
|
/// you only want to run once, perhaps because they're expensive.
|
|
///
|
|
/// The cache purely type based so you can only cache one value of each type. The cache is also
|
|
/// local to the current request and not reused across requests.
|
|
///
|
|
/// # Example
|
|
///
|
|
/// ```rust
|
|
/// use axum_extra::extract::Cached;
|
|
/// use axum::{
|
|
/// async_trait,
|
|
/// extract::FromRequestParts,
|
|
/// body::BoxBody,
|
|
/// response::{IntoResponse, Response},
|
|
/// http::{StatusCode, request::Parts},
|
|
/// };
|
|
///
|
|
/// #[derive(Clone)]
|
|
/// struct Session { /* ... */ }
|
|
///
|
|
/// #[async_trait]
|
|
/// impl<S> FromRequestParts<S> for Session
|
|
/// where
|
|
/// S: Send + Sync,
|
|
/// {
|
|
/// type Rejection = (StatusCode, String);
|
|
///
|
|
/// async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> {
|
|
/// // load session...
|
|
/// # unimplemented!()
|
|
/// }
|
|
/// }
|
|
///
|
|
/// struct CurrentUser { /* ... */ }
|
|
///
|
|
/// #[async_trait]
|
|
/// impl<S> FromRequestParts<S> for CurrentUser
|
|
/// where
|
|
/// S: Send + Sync,
|
|
/// {
|
|
/// type Rejection = Response;
|
|
///
|
|
/// async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> {
|
|
/// // loading a `CurrentUser` requires first loading the `Session`
|
|
/// //
|
|
/// // by using `Cached<Session>` we avoid extracting the session more than
|
|
/// // once, in case other extractors for the same request also loads the session
|
|
/// let session: Session = Cached::<Session>::from_request_parts(parts, state)
|
|
/// .await
|
|
/// .map_err(|err| err.into_response())?
|
|
/// .0;
|
|
///
|
|
/// // load user from session...
|
|
/// # unimplemented!()
|
|
/// }
|
|
/// }
|
|
///
|
|
/// // handler that extracts the current user and the session
|
|
/// //
|
|
/// // the session will only be loaded once, even though `CurrentUser`
|
|
/// // also loads it
|
|
/// async fn handler(
|
|
/// current_user: CurrentUser,
|
|
/// // we have to use `Cached<Session>` here otherwise the
|
|
/// // cached session would not be used
|
|
/// Cached(session): Cached<Session>,
|
|
/// ) {
|
|
/// // ...
|
|
/// }
|
|
/// ```
|
|
///
|
|
/// [request extensions]: http::Extensions
|
|
#[derive(Debug, Clone, Default)]
|
|
pub struct Cached<T>(pub T);
|
|
|
|
#[derive(Clone)]
|
|
struct CachedEntry<T>(T);
|
|
|
|
#[async_trait]
|
|
impl<S, B, T> FromRequest<S, B> for Cached<T>
|
|
where
|
|
B: Send + 'static,
|
|
S: Send + Sync,
|
|
T: FromRequestParts<S> + Clone + Send + Sync + 'static,
|
|
{
|
|
type Rejection = T::Rejection;
|
|
|
|
async fn from_request(req: Request<B>, state: &S) -> Result<Self, Self::Rejection> {
|
|
let (mut parts, _) = req.into_parts();
|
|
|
|
match Extension::<CachedEntry<T>>::from_request_parts(&mut parts, state).await {
|
|
Ok(Extension(CachedEntry(value))) => Ok(Self(value)),
|
|
Err(_) => {
|
|
let value = T::from_request_parts(&mut parts, state).await?;
|
|
parts.extensions.insert(CachedEntry(value.clone()));
|
|
Ok(Self(value))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#[async_trait]
|
|
impl<S, T> FromRequestParts<S> for Cached<T>
|
|
where
|
|
S: Send + Sync,
|
|
T: FromRequestParts<S> + Clone + Send + Sync + 'static,
|
|
{
|
|
type Rejection = T::Rejection;
|
|
|
|
async fn from_request_parts(parts: &mut Parts, state: &S) -> Result<Self, Self::Rejection> {
|
|
match Extension::<CachedEntry<T>>::from_request_parts(parts, state).await {
|
|
Ok(Extension(CachedEntry(value))) => Ok(Self(value)),
|
|
Err(_) => {
|
|
let value = T::from_request_parts(parts, state).await?;
|
|
parts.extensions.insert(CachedEntry(value.clone()));
|
|
Ok(Self(value))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T> Deref for Cached<T> {
|
|
type Target = T;
|
|
|
|
fn deref(&self) -> &Self::Target {
|
|
&self.0
|
|
}
|
|
}
|
|
|
|
impl<T> DerefMut for Cached<T> {
|
|
fn deref_mut(&mut self) -> &mut Self::Target {
|
|
&mut self.0
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use axum::{extract::FromRequestParts, http::Request};
|
|
use http::request::Parts;
|
|
use std::{
|
|
convert::Infallible,
|
|
sync::atomic::{AtomicU32, Ordering},
|
|
time::Instant,
|
|
};
|
|
|
|
#[tokio::test]
|
|
async fn works() {
|
|
static COUNTER: AtomicU32 = AtomicU32::new(0);
|
|
|
|
#[derive(Clone, Debug, PartialEq, Eq)]
|
|
struct Extractor(Instant);
|
|
|
|
#[async_trait]
|
|
impl<S> FromRequestParts<S> for Extractor
|
|
where
|
|
S: Send + Sync,
|
|
{
|
|
type Rejection = Infallible;
|
|
|
|
async fn from_request_parts(
|
|
_parts: &mut Parts,
|
|
_state: &S,
|
|
) -> Result<Self, Self::Rejection> {
|
|
COUNTER.fetch_add(1, Ordering::SeqCst);
|
|
Ok(Self(Instant::now()))
|
|
}
|
|
}
|
|
|
|
let (mut parts, _) = Request::new(()).into_parts();
|
|
|
|
let first = Cached::<Extractor>::from_request_parts(&mut parts, &())
|
|
.await
|
|
.unwrap()
|
|
.0;
|
|
assert_eq!(COUNTER.load(Ordering::SeqCst), 1);
|
|
|
|
let second = Cached::<Extractor>::from_request_parts(&mut parts, &())
|
|
.await
|
|
.unwrap()
|
|
.0;
|
|
assert_eq!(COUNTER.load(Ordering::SeqCst), 1);
|
|
|
|
assert_eq!(first, second);
|
|
}
|
|
}
|