tokio-rs/axum
1
0
Fork 0
mirror of https://github.com/tokio-rs/axum.git synced 2026-08-26 00:00:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make extractors easier to write (#36)

Browse Source 
Previously extractors worked directly on `Request<B>` which meant you
had to do weird tricks like `mem::take(req.headers_mut())` to get owned
parts of the request.

This changes that instead to use a new `RequestParts` type that have
methods to "take" each part of the request. Without having to do weird
tricks.

Also removed the need to have `B: Default` for body extractors.
This commit is contained in:
David Pedersen
2021-07-22 13:23:50 +02:00
committed by GitHub
parent e544fe1c39
commit f32d325e55
12 changed files with 441 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tests.rs
+7 -3
View File
@@ -1,4 +1,7 @@
use crate::{handler::on, prelude::*, response::IntoResponse, routing::MethodFilter, service};
use crate::{
extract::RequestParts, handler::on, prelude::*, response::IntoResponse, routing::MethodFilter,
service,
};
use bytes::Bytes;
use http::{header::AUTHORIZATION, Request, Response, StatusCode};
use hyper::{Body, Server};
@@ -105,7 +108,7 @@ async fn consume_body_to_json_requires_json_content_type() {
let app = route(
"/",
post(|_: Request<Body>, input: extract::Json<Input>| async { input.0.foo }),
post(|input: extract::Json<Input>| async { input.0.foo }),
);
let addr = run_in_background(app).await;
@@ -675,9 +678,10 @@ async fn test_extractor_middleware() {
{
type Rejection = StatusCode;
async fn from_request(req: &mut Request<B>) -> Result<Self, Self::Rejection> {
async fn from_request(req: &mut RequestParts<B>) -> Result<Self, Self::Rejection> {
if let Some(auth) = req
.headers()
.expect("headers already extracted")
.get("authorization")
.and_then(|v| v.to_str().ok())
{