From 90dbd52ee4d497a4e9871eeeeb156677f6a82c5f Mon Sep 17 00:00:00 2001 From: David Pedersen Date: Wed, 17 Aug 2022 11:41:52 +0200 Subject: [PATCH] Fix lint warnings (#1267) --- axum-extra/src/extract/with_rejection.rs | 2 +- axum-extra/src/protobuf.rs | 6 +++--- axum/src/extract/path/mod.rs | 4 ++-- axum/src/json.rs | 1 - 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/axum-extra/src/extract/with_rejection.rs b/axum-extra/src/extract/with_rejection.rs index 82ee2027..e6387f6c 100644 --- a/axum-extra/src/extract/with_rejection.rs +++ b/axum-extra/src/extract/with_rejection.rs @@ -80,7 +80,7 @@ where E: Clone, { fn clone(&self) -> Self { - Self(self.0.clone(), self.1.clone()) + Self(self.0.clone(), self.1) } } diff --git a/axum-extra/src/protobuf.rs b/axum-extra/src/protobuf.rs index 823c98e3..adad7280 100644 --- a/axum-extra/src/protobuf.rs +++ b/axum-extra/src/protobuf.rs @@ -236,7 +236,7 @@ mod tests { ); let input = Input { - foo: "bar".to_string(), + foo: "bar".to_owned(), }; let client = TestClient::new(app); @@ -264,7 +264,7 @@ mod tests { let app = Router::new().route("/", post(|_: ProtoBuf| async {})); let input = Input { - foo: "bar".to_string(), + foo: "bar".to_owned(), }; let client = TestClient::new(app); @@ -299,7 +299,7 @@ mod tests { ); let input = Input { - foo: "bar".to_string(), + foo: "bar".to_owned(), }; let client = TestClient::new(app); diff --git a/axum/src/extract/path/mod.rs b/axum/src/extract/path/mod.rs index 20a23ce7..ab298143 100644 --- a/axum/src/extract/path/mod.rs +++ b/axum/src/extract/path/mod.rs @@ -187,7 +187,7 @@ where } }; - T::deserialize(de::PathDeserializer::new(&*params)) + T::deserialize(de::PathDeserializer::new(params)) .map_err(|err| { PathRejection::FailedToDeserializePathParams(FailedToDeserializePathParams(err)) }) @@ -260,7 +260,7 @@ impl std::error::Error for PathDeserializationError {} /// /// This type is obtained through [`FailedToDeserializePathParams::into_kind`] and is useful for building /// more precise error messages. -#[derive(Debug, PartialEq)] +#[derive(Debug, PartialEq, Eq)] #[non_exhaustive] pub enum ErrorKind { /// The URI contained the wrong number of parameters. diff --git a/axum/src/json.rs b/axum/src/json.rs index 6f4b0988..3fd83a4b 100644 --- a/axum/src/json.rs +++ b/axum/src/json.rs @@ -247,7 +247,6 @@ mod tests { let res = client.post("/").body(r#"{ "foo": "bar" }"#).send().await; let status = res.status(); - dbg!(res.text().await); assert_eq!(status, StatusCode::UNSUPPORTED_MEDIA_TYPE); }