a107f24fb0
feat: backport cache read-denied + ACTIONS_CACHE_MODE handling (5.2.0) ( #2451 )
...
Backport of the read-denied and ACTIONS_CACHE_MODE cache-mode gating from
the ESM v6.2.0 line (#2447 ) to the CommonJS v5 line, released as 5.2.0.
Mirrors the earlier write-denied backport (#2435 , 5.1.0).
- Detect the `cache read denied:` prefix on download failures (v2 twirp
path and v1 `_apis/artifactcache` path) and surface it as a core.warning
without failing the run.
- Honor ACTIONS_CACHE_MODE: skip restore when the effective cache-mode does
not permit reads (none, write-only) and skip save when it does not permit
writes (none, read), logging a single non-fatal core.info line. Unset or
unrecognized modes are unchanged.
- Add read-denied and cache-mode tests; bump to 5.2.0 with RELEASES entry.
Copilot-Session: e96deec1-716e-4e14-acdf-a230139420a2
Co-authored-by: Copilot App <[email protected]
2026-07-15 13:13:58 -05:00
Jason Ginchereau and Jason Ginchereau
c6ca5e729f
Backport: Handle cache write error due to RO token ( #2435 )
2026-06-17 17:21:17 -07:00
Ryan Ghadimi
06f7fd9df1
new error state, tests to cover
2025-08-13 13:00:46 +00:00
Ryan Ghadimi
0fe20e9d56
remove cache size limit
2025-08-13 10:14:18 +00:00
Bassem Dghaidi and GitHub
6d3feab2bf
Merge pull request #2100 from actions/copilot/fix-2099
...
Improve cache service availability determination and implement conditional error logging
2025-07-28 16:49:10 +02:00
copilot-swe-agent[bot] and Link-
bd54a2413a
Fix v1 cache service to only check ACTIONS_CACHE_URL
...
Co-authored-by: Link- <[email protected]
2025-07-14 13:39:13 +00:00
copilot-swe-agent[bot] and Link-
d48d6b62a4
Remove logCacheError function and implement inline 5xx error detection as requested
...
Co-authored-by: Link- <[email protected]
2025-07-14 12:42:37 +00:00
copilot-swe-agent[bot] and Link-
c51178a15e
Implement 5xx server error detection and fix most cache tests
...
Co-authored-by: Link- <[email protected]
2025-07-14 12:23:44 +00:00
copilot-swe-agent[bot] and Link-
cf3aaeb491
Update tests to expect warnings instead of errors for non-5xx cache failures
...
Co-authored-by: Link- <[email protected]
2025-07-14 12:07:37 +00:00
Bassem Dghaidi and GitHub
cf4886cccb
Fix linting issues
2025-07-14 03:49:28 -07:00
Bassem Dghaidi and GitHub
0c5da92b52
Fix logging of cache key and restore key matches
2025-07-14 03:45:17 -07:00
copilot-swe-agent[bot] and Link-
3c90578c30
Improve cache service availability determination and change warnings to errors
...
- Update isFeatureAvailable() to leverage ACTIONS_CACHE_SERVICE_V2 feature flag
- For v2: check ACTIONS_RESULTS_URL availability
- For v1: check either ACTIONS_CACHE_URL or ACTIONS_RESULTS_URL availability
- Change warning logs to error logs for cache failures
- Add comprehensive tests covering all scenarios
Co-authored-by: Link- <[email protected]
2025-07-14 10:32:34 +00:00
Art Leo
514314311c
Log cache version requested
2025-03-15 10:13:43 +11:00
Rob Herley
d096588f08
cache: wrap create failures in ReserveCacheError
2025-02-25 12:49:08 -05:00
Rob Herley
e6fb8f1c5d
cache miss as debug, not warning annotation
2025-02-14 09:28:01 -05:00
Bassem Dghaidi and GitHub
c02c929c56
Minor comment adjustments
2024-12-02 11:10:25 -08:00
Bassem Dghaidi and GitHub
c649df4b94
Minor comment adjustments
2024-12-02 10:55:33 -08:00
Bassem Dghaidi and GitHub
fb40492b6f
Merge branch 'enhance-blob-client' of github.com:actions/toolkit into enhance-blob-client
2024-12-02 10:55:00 -08:00
Bassem Dghaidi and GitHub
502e8ce651
Minor comment adjustments
2024-12-02 10:53:29 -08:00
3f7df8ec5a
Fix comments
...
Co-authored-by: Josh Gross <[email protected]
2024-12-02 19:46:18 +01:00
b24632bd80
Fix comments
...
Co-authored-by: Josh Gross <[email protected]
2024-12-02 19:46:11 +01:00
Bassem Dghaidi and GitHub
a762876d6d
Minor refactoring
2024-12-02 04:08:21 -08:00
Bassem Dghaidi and GitHub
d89855bb90
Fix upload progress bug
2024-12-02 03:55:57 -08:00
Bassem Dghaidi and GitHub
db1d01308c
Troubleshoot
2024-12-02 03:35:20 -08:00
Bassem Dghaidi and GitHub
1d403c2fd8
Fix tests
2024-11-29 07:36:51 -08:00
Bassem Dghaidi and GitHub
65892d5ffe
Fine tune blob uploads
2024-11-29 07:09:05 -08:00
Bassem Dghaidi and GitHub
8c5f6f2dc5
Force use of Azure for restoreCacheV2
2024-11-28 07:42:07 -08:00
Bassem Dghaidi and GitHub
62f5f1885b
Refactor saveCacheV2 to use saveCache from cacheHttpClient
2024-11-28 07:22:01 -08:00
Bassem Dghaidi and GitHub
eaf0083ee2
Respect download options for restore
2024-11-28 04:56:37 -08:00
Bassem Dghaidi and GitHub
c1fb081674
Linter fixes
2024-11-28 03:53:34 -08:00
Bassem Dghaidi and GitHub
df166709a3
Refactor cache upload functionality and improve test cases
2024-11-28 03:52:09 -08:00
Bassem Dghaidi and GitHub
35d87ab129
Refactor code formatting for consistency and readability
2024-11-27 05:58:22 -08:00
Bassem Dghaidi and GitHub
af3981c955
Update the useragent of the old http client to pass cache version
2024-11-27 05:50:01 -08:00
Bassem Dghaidi and GitHub
27e5cf2514
Replace downloadCacheFile with downloadCacheStorageSDK
2024-11-27 04:51:21 -08:00
John Sudol
46174ed573
run prettier
2024-11-26 00:56:07 +00:00
John Sudol
1f087496ca
Add debug message for uploadResponse
2024-11-26 00:43:37 +00:00
John Sudol
8f606682c2
Add saveCacheV2 tests
2024-11-26 00:23:42 +00:00
Bassem Dghaidi and GitHub
4d31e1048a
Add the download cache file status code to debug log
2024-11-25 07:34:52 -08:00
Bassem Dghaidi and GitHub
0e321b26f4
Add the download cache file status code to debug log
2024-11-25 07:34:07 -08:00
Bassem Dghaidi and GitHub
de236da416
Fix cache lookup scenario
2024-11-25 05:47:51 -08:00
Bassem Dghaidi and GitHub
4dadd612d6
Add support for matching on restore key values
2024-11-25 05:42:50 -08:00
Bassem Dghaidi and GitHub
54ac2dd012
Add cache service version debug message
2024-11-25 04:08:47 -08:00
Bassem Dghaidi and GitHub
4de30f744e
Add more tests for restoreCacheV2
2024-11-25 03:53:03 -08:00
Bassem Dghaidi and GitHub
39d19810a8
Add restore tests
2024-11-22 09:01:59 -08:00
Bassem Dghaidi and GitHub
e2028d43a2
Linter fixes and remove unnecessary dependency
2024-11-21 04:05:04 -08:00
Bassem Dghaidi and GitHub
267841d7bd
Add isGhes gate and refactor to clean up circular dependencies
2024-11-21 04:01:44 -08:00
Bassem Dghaidi and GitHub
a1e6ef3759
Update cache service APIs & cleanup
2024-11-20 13:53:47 -08:00
Bassem Dghaidi and GitHub
8616c313a2
Remove unused definitions
2024-11-14 07:11:12 -08:00
Bassem Dghaidi and GitHub
3ca85474b8
Merge branch 'neo-cache-service' of github.com:actions/toolkit into neo-cache-service
2024-11-14 06:50:01 -08:00
Bassem Dghaidi and GitHub
6c11d441a5
Remove unnecessary type hints
2024-11-14 06:49:55 -08:00
