* feat(cache): surface cache read-denied as a distinct restore warning
Mirror the existing cache write-denied handling on the restore path. When
the receiver refuses a download URL because the run's token has no readable
cache scopes, it returns a twirp PermissionDenied (HTTP 403). The twirp
client wraps that 403 in a generic Error, so the stable 'cache read denied:'
prefix is embedded in the message rather than at the start.
- Add CACHE_READ_DENIED_PREFIX and CacheReadDeniedError
- Dispatch on the prefix in the restoreCacheV2 catch block (V2 only), log a
policy-specific warning, and report a cache miss so the run continues
- Add a test mirroring the write-denied coverage
* chore(cache): trim comments, bump to 6.2.0, add RELEASES entry
* refactor(cache): dispatch read-denied by error name to mirror write path
Re-throw CacheReadDeniedError from an inner try/catch around
GetCacheEntryDownloadURL and dispatch on typedError.name in the outer catch,
matching how saveCacheV2 handles CacheWriteDeniedError.
* feat(cache): handle read-denied on the v1 restore path
Extend the read-denied handling to Cache Service v1 so GHES (which forces v1
via _apis/artifactcache) is covered when read-scope enforcement ships there.
- Surface the receiver's error body message from getCacheEntry instead of a
generic status-code error, so the cache read denied: prefix reaches callers
- Re-throw CacheReadDeniedError from restoreCacheV1 and dispatch on it in the
outer catch, mirroring restoreCacheV2 and the write-denied v1 handling
- Add a v1 read-denied test
* refactor(cache): only surface receiver body for read-denied on v1
* test(cache): assert getCacheEntry only surfaces body for read-denied
* test(cache): cover non-read-denied getCacheEntry passthrough on v1
* refactor(cache): share read-denied prefix via constants to avoid drift
* feat(cache): skip restore/save per ACTIONS_CACHE_MODE
* test(cache): expand ACTIONS_CACHE_MODE skip coverage across v1/v2 and unknown modes
* fix copilot pr feedback
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
* docs(cache): remove internal reference from cache-mode comment
* test(cache): merge redundant cache-mode skip tests and simplify read-denied handling
Address PR review feedback:
- Merge the duplicate restore/save skip test.each blocks into single blocks parametrized over ACTIONS_CACHE_SERVICE_V2.
- Drop the redundant CacheReadDeniedError catch arms; the typed error is not an HttpClientError so it already falls through to a non-fatal warning.
- Clarify why read-denied classification happens both in getCacheEntry and cache.ts (dependency-free internal module cannot import the typed error).
* refactor(cache): drop redundant CacheWriteDeniedError catch arms
Mirror the read-denied simplification on the save path. CacheWriteDeniedError
is not an HttpClientError and its name does not match the ReserveCacheError
arm, so it falls through to the same non-fatal warning. Logging behavior is
unchanged (warns, never fails the run) and the exported type is still thrown
internally for consumers and tests. Also refresh stale doc wording.
* test(cache): collapse redundant restore getCacheEntry-failure tests
The two restoreCache tests exercised the identical warning + cache-miss path
now that read-denied is no longer reclassified in the catch, so merge them into
one. The read-denied prefix detection that actually branches on the message is
covered by getCacheEntry tests in cacheHttpClient.test.ts.
---------
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
- Update restoreCacheV2.test.ts, restoreCache.test.ts, saveCacheV2.test.ts, and saveCache.test.ts
- Change test expectations from core.warning to core.error for cache operation failures
- All tests now pass successfully
Co-authored-by: Link- <[email protected]>
* bsd + zstd fallback implementation
* bsd + zstd fallback implementation
* Fix tar operations
* Add -v option for testing
* Fix order of args for tar
* Add GNUtar as default on windows
* Fix test
* Fix tar tests
* Fix lint issues
* Fix windows gnutar test case
* Temporarily remove thhe condition that prevents zstd usage on windows unless with GNUtar
* Address some comments and correct compression commands
* Add windows bsdtar test
* Fix windows test
* Fix test
* Separate args
* Fix old tests
* Add new tests
* Fix tests
* Fix lint test
* Refactor code
* Address review comments
* Fix test
* Fix tar test
* Add await to async function calls
* Fix test
* Update for beta release
* Fix audit issues
* Add fallback to gzip compression if cache not found
* Fix test
* Add test
* Address review comments
* Revert Address review comments
* Release 3.1.0-beta.2 cache package
* Fix issues
* Reconfigure catch block
* Add debug logging for gzip fall back
* Fix test
* Add end to end test for cache using bsd on windows
and address review comments
* Fix test
* Fix test
* Fix tests
* Add better comments
* Update packages/cache/src/internal/cacheHttpClient.ts
Co-authored-by: Bishal Prasad <[email protected]>
* Address review comments
* Update for new beta cache package release
* Address bugbash issues
* Fix tests
* Release new actions/cache minor version
Co-authored-by: Lovepreet Singh <[email protected]>
Co-authored-by: Bishal Prasad <[email protected]>
* Initial changes
* added info error as well
* Format
* Unused package
* adding message field
* removed line
* Review comments
* review comment to add validation as errors handling
* Adds option to download using AzCopy
* Bump version number and add release notes
* Ensure we use at least v10
* Negate env var so it disables AzCopy
* Use Azure storage SDK to download cache
* Use same level of parallelism as AzCopy
* Fix naming of variable
* React to feedback
* Bump Node types to Node 12
* Make linter happy
* Pass options into restoreCache method
* Fix tests
* Restructure files and add tests
* Add method to get the default download and upload options
* Include breaking changes in RELEASES.md
Co-authored-by: Josh Gross <[email protected]>
