actions/toolkit
2
0
Fork 0
mirror of https://github.com/actions/toolkit.git synced 2026-08-23 00:00:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: use detached:true on all platforms for exec stream tests

Browse Source 
On Windows, detached:true is needed to properly keep stdio handles
open after the parent process exits.
This commit is contained in:
Salman Muin Kayser Chishti
2025-12-08 12:35:33 +00:00
parent 894f77901e
commit bf1b64008f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/exec/__tests__/scripts/spawn-wait-for-file.js
+6 -1
View File
@@ -19,9 +19,14 @@ if (!filePath) {
// This creates a grandchild process that holds the stdio handles open // This creates a grandchild process that holds the stdio handles open
// after this process (the child) exits // after this process (the child) exits
const waitScript = path.join(__dirname, 'wait-for-file.js') const waitScript = path.join(__dirname, 'wait-for-file.js')
const isWindows = process.platform === 'win32'
// On Windows, use detached:true to properly keep streams open
// On Unix, detached:true also works and creates a new process group
const child = childProcess.spawn(process.execPath, [waitScript, `file=${filePath}`], { const child = childProcess.spawn(process.execPath, [waitScript, `file=${filePath}`], {
stdio: ['ignore', 'inherit', 'inherit'], stdio: ['ignore', 'inherit', 'inherit'],
detached: process.platform !== 'win32' detached: true,
windowsHide: true
}) })
// Don't wait for child to exit // Don't wait for child to exit