Handle Encoded URL for Proxy Username and Password in HTTP Client (#1782)

* uri-decode-fix Signed-off-by: Yu <[email protected]> * http-client URLdecode fix Signed-off-by: Yu <[email protected]> * http-client URLdecode test typo fix Signed-off-by: Yu <[email protected]> --------- Signed-off-by: Yu <[email protected]>
2026-08-14 00:00:18 +02:00 · 2024-08-16 12:43:10 -04:00
parent 279e891118
commit 1b9927d1c7
2 changed files with 33 additions and 2 deletions
@@ -15,10 +15,10 @@ export function getProxyUrl(reqUrl: URL): URL | undefined {

  if (proxyVar) {
    try {
-      return new URL(proxyVar)
+      return new DecodedURL(proxyVar)
    } catch {
      if (!proxyVar.startsWith('http://') && !proxyVar.startsWith('https://'))
-        return new URL(`http://${proxyVar}`)
+        return new DecodedURL(`http://${proxyVar}`)
    }
  } else {
    return undefined
@@ -87,3 +87,22 @@ function isLoopbackAddress(host: string): boolean {
    hostLower.startsWith('[0:0:0:0:0:0:0:1]')
  )
 }
+
+class DecodedURL extends URL {
+  private _decodedUsername: string
+  private _decodedPassword: string
+
+  constructor(url: string | URL, base?: string | URL) {
+    super(url, base)
+    this._decodedUsername = decodeURIComponent(super.username)
+    this._decodedPassword = decodeURIComponent(super.password)
+  }
+
+  get username(): string {
+    return this._decodedUsername
+  }
+
+  get password(): string {
+    return this._decodedPassword
+  }
+}